invocation: rephrase slightly the proof rules to be less confusing down the line #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoyer64
requested changes
Dec 9, 2024
MichaelMure
force-pushed
the
proof-rephrase
branch
from
32b6444 to
80c2d60
Compare
- for invocation, reorder the parameters for a more "natural language" mental model - for delegation, make "subject" a required parameter to avoid make powerline by mistake - for delegation, implement powerline
|
close #75 |
smoyer64
reviewed
Dec 10, 2024
| // using the public key associated with the private key sent as the first | ||
| // parameter. | ||
| func New(iss, aud did.DID, cmd command.Command, pol policy.Policy, opts ...Option) (*Token, error) { | ||
| // You can read it as "(issuer) allows (audience) to perform (cmd+pol) on (subject)". |
There was a problem hiding this comment.
Glad you included these - I was thinking overnight that we could also state these in "user story" form. Perhaps something like "As an Issuer, I want to allow my Audience to Invoke Command+Policy on Subject". I tried to be consistent with https://github.com/ucan-wg/spec?tab=readme-ov-file#roles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.